[v1.27.0] Tests: IPFS download #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Karrenbelt
commented
Dec 24, 2022
|
|
||
| if is_dir: | ||
| assert len(all_new_paths) == 4 | ||
| assert not any(self.some_ipfs_hash in str(p) for p in all_new_paths) |
There was a problem hiding this comment.
because we default to fix_path = True
Karrenbelt
commented
Dec 24, 2022
| "shutil.copytree" | ||
| "shutil.copy" |
There was a problem hiding this comment.
this mock was hiding an issue
Codecov ReportBase: 90.29% // Head: 90.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
=======================================
Coverage 90.29% 90.30%
=======================================
Files 352 352
Lines 28700 28702 +2
=======================================
+ Hits 25916 25920 +4
+ Misses 2784 2782 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Karrenbelt
commented
Dec 24, 2022
Comment on lines
-339
to
+342
| shutil.copytree(download_path, downloaded_path) | ||
| if download_path.is_dir(): | ||
| shutil.copytree(download_path, downloaded_path) | ||
| else: | ||
| shutil.copy(download_path, downloaded_path) |
There was a problem hiding this comment.
immediate fix, cleaned up in #480
Karrenbelt
commented
Dec 24, 2022
Comment on lines
-357
to
+360
| if fix_path: | ||
| if fix_path and Path(downloaded_path).is_dir(): |
DavidMinarsch
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Added test (and fix) for handling a IPFS that points to a single file rather than a directory.
partially addresses #501
#480 will be revisited and stacked on top of this PR.
Fixes
If it fixes a bug or resolves a feature request, be sure to link to that issue.
Types of changes
What types of changes does your code introduce to agents-aea?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.developbranch (left side). Also you should start your branch off ourdevelop.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...