Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Argon2 #42

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Update to Argon2 #42

wants to merge 13 commits into from

Conversation

jmoreira-valory
Copy link
Collaborator

@jmoreira-valory jmoreira-valory commented Mar 1, 2025

Proposed changes

Update password hash to Argon2, winner of the Password Hashing Competition.

  • Upon successful login, the middleware will update the current hash format to Argon2.
  • If login is unsuccessful, it will not modify the hash value.

⚠️ Breaking change!!!
Once the .operate folder is loaded with this version of the middleware, the folder will no longer work with older versions. (The recommendation is to backup the . operate folder if the user intends to use it with older versions.)

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@@ -139,7 +141,7 @@ exclude=.md,
packages/valory/protocols/ledger_api
operate/data/
max-line-length = 88
select = B,C,D,E,F,I,W,
select = B,C,D,E,F,I,W,PT
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PT = Pytest style. Suggestion to include it in tomte repository.

@jmoreira-valory jmoreira-valory requested a review from dagacha March 1, 2025 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants