feat: Bug of not showing the correct amount in today's rewards when staking later during epoch #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t integration (lots going on)
… calculations and logging
… reward calculations
…Schema for clarity
… reward calculations and clarity
mohandast52
commented
Feb 7, 2025
truemiller
approved these changes
Feb 7, 2025
frontend/context/RewardProvider.tsx
Outdated
| // if agent is not staked, return the available rewards for the epoch | ||
| // i.e, agent has not yet started staking | ||
| if (isNil(serviceStakingStartTime) || serviceStakingStartTime === 0) { | ||
| return parseFloat(formatUnits(`${availableRewardsForEpoch}`)); |
There was a problem hiding this comment.
don't understand why if not staked return full amount, but if staked but not yet eligible return undefined?
There was a problem hiding this comment.
where are we returning undefined?
There was a problem hiding this comment.
ah ok, removed.
Tanya-atatakai
approved these changes
Feb 10, 2025
…isEpoch calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply