(govern) feat: add possibility to reset all votes #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kupermind
approved these changes
Dec 4, 2024
…into tanya/votes-reset
atepem
approved these changes
Mar 3, 2025
mohandast52
approved these changes
Mar 3, 2025
| queryClient.removeQueries({ | ||
| predicate: (query) => | ||
| INVALIDATE_AFTER_UPDATE_KEYS.includes( | ||
| (query.queryKey[1] as Record<string, string>)?.scopeKey, |
There was a problem hiding this comment.
it's the object of the query that includes all keys (arguments, scopeKey, etc.) related to particular readContract
| }); | ||
|
|
||
| // Reset previously saved data so it's re-fetched automatically | ||
| queryClient.removeQueries({ |
There was a problem hiding this comment.
why not "invalidateQueries"? do we not want to refetch it?
There was a problem hiding this comment.
if using invalidate, afair some related useEffects won't be recalculated because saved cache will remain and just replaces with refetched data, while I needed it like the whole page was reloaded without actual reloading
TanStack/query#3169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply