Add support for defining priorityClassName #56
+11
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtirloni
force-pushed
the
priorityclass
branch
from
a0dd930 to
6ea9b9e
Compare
|
Thanks for the PR! A couple notes:
Otherwise, LGTM. |
gtirloni
force-pushed
the
priorityclass
branch
from
6ea9b9e to
1ec1299
Compare
|
@sgissi thank you for the review. I've updated the PR. |
gtirloni
force-pushed
the
priorityclass
branch
2 times, most recently
from
e15bd29 to
da08dfd
Compare
|
Looks CI failed because it can't download helm. Related: helm/helm#31437 |
|
Sounds like it recovered now. It is just missing a comment on values.yaml above the new entry. @mk-raven LTGM after the comment is added. |
https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/ Signed-off-by: Giovanni Tirloni <[email protected]>
gtirloni
force-pushed
the
priorityclass
branch
from
da08dfd to
8c7b832
Compare
|
Fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/