-
Notifications
You must be signed in to change notification settings - Fork 23
Add cluster mode support #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
qjsoq
wants to merge
14
commits into
valkey-io:main
Choose a base branch
from
qjsoq:cluster-enable-branch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmytro Artamonov <[email protected]>
Signed-off-by: Dmytro Artamonov <[email protected]>
Signed-off-by: Dmytro Artamonov <[email protected]>
Signed-off-by: Dmytro Artamonov <[email protected]>
Signed-off-by: Dmytro Artamonov <[email protected]>
Signed-off-by: Dmytro Artamonov <[email protected]>
Signed-off-by: Dmytro Artamonov <[email protected]>
Signed-off-by: Dmytro Artamonov <[email protected]>
Signed-off-by: Dmytro Artamonov <[email protected]>
Signed-off-by: Dmytro Artamonov <[email protected]>
Signed-off-by: Dmytro Artamonov <[email protected]>
Signed-off-by: Dmytro Artamonov <[email protected]>
Signed-off-by: Dmytro Artamonov <[email protected]>
Signed-off-by: Dmytro Artamonov <[email protected]>
4691cd5 to
e5d63e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new, comprehensive Helm chart named valkey-cluster for deploying a clustered Valkey instance on Kubernetes.
This chart is designed to handle the complexities of a clustered setup by leveraging a StatefulSet and an intelligent initialization script.
What This PR Does:
How the Auto-Clustering Works
The core of the cluster logic resides in the
init-cluster.shscript, which runs as a background process in the main container:Peer Discovery: Each pod uses the Kubernetes headless service to discover its peers.
Joining an Existing Cluster: If a new pod starts and discovers an already healthy cluster, it uses the
CLUSTER MEETcommand to join. It then intelligently finds a master with a deficit of replicas and assigns itself as a replica usingCLUSTER REPLICATE.Initial Cluster Creation: If no cluster is found, the first pod (-0) takes on the role of the initiator. It waits for all other pods to become ready and then bootstraps the entire cluster using the
valkey-cli --cluster createcommand with the appropriate number of replicas.Resiliency: The script can handle pods restarting by attempting to re-join the cluster and forget its old failed entry if necessary.
Here are some screenshots demonstrating the chart in action after a successful deployment.
For deployment these settings were set:
This shows the successful formation of a 6-node cluster (3 masters, 3 replicas).
This confirms that the StatefulSet has successfully created all pods and their corresponding PersistentVolumeClaims.