Skip to content

CI: Add intel mac #3482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
May 13, 2025
Merged

CI: Add intel mac #3482

merged 13 commits into from
May 13, 2025

Conversation

Yury-Fridlyand
Copy link
Collaborator

@Yury-Fridlyand Yury-Fridlyand commented Apr 1, 2025

  • Add intel mac back to CI/CD.
  • Update docs.
  • Disable CI on that platform. It works, but some tests are very unstable.
  • Related CI/CD changes.
  • Create and publish RC from this branch to ensure that CD works properly end-to-end.

See CI/CD runs on that branch.

Issue link

This Pull Request is linked to issue (URL): fixes #3443

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Commits will be squashed upon merging.

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Copy link
Member

@avifenesh avifenesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, it needs to be added to all CDs, and back to package.json optionals.
It seems like deep work done for java, but validate python and node missing.
You can check @jbrinkman p
PR for removing it from package.json and nodejs readme and update it back.
Please also check messages in the channels regarding mac build.

For Ubuntu - please change the matrix to use the oldest available for now, and update the readme to version+

Signed-off-by: Yury-Fridlyand <[email protected]>
@Yury-Fridlyand Yury-Fridlyand marked this pull request as ready for review May 9, 2025 20:15
@Yury-Fridlyand Yury-Fridlyand requested a review from a team as a code owner May 9, 2025 20:15
@Yury-Fridlyand Yury-Fridlyand mentioned this pull request May 9, 2025
6 tasks
Copy link
Collaborator

@edlng edlng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@jbrinkman jbrinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Collaborator

@jamesx-improving jamesx-improving left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need another issue to track adding back CI to Intel-Mac as well?

@Yury-Fridlyand Yury-Fridlyand merged commit b8885ba into main May 13, 2025
58 of 64 checks passed
@Yury-Fridlyand Yury-Fridlyand deleted the ci/yuryf-intel-mac branch May 13, 2025 00:16
shohamazon pushed a commit that referenced this pull request May 13, 2025
* Add intel mac

Signed-off-by: Yury-Fridlyand <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD CI/CD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for intel mac
6 participants