-
Notifications
You must be signed in to change notification settings - Fork 93
CI: Add intel mac #3482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add intel mac #3482
Conversation
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, it needs to be added to all CDs, and back to package.json optionals.
It seems like deep work done for java, but validate python and node missing.
You can check @jbrinkman p
PR for removing it from package.json and nodejs readme and update it back.
Please also check messages in the channels regarding mac build.
For Ubuntu - please change the matrix to use the oldest available for now, and update the readme to version+
Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: Yury-Fridlyand <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Signed-off-by: Yury-Fridlyand <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do we need another issue to track adding back CI to Intel-Mac as well?
* Add intel mac Signed-off-by: Yury-Fridlyand <[email protected]>
See CI/CD runs on that branch.
Issue link
This Pull Request is linked to issue (URL): fixes #3443
Checklist
Before submitting the PR make sure the following are checked: