PHP: Add logging #68

prateek-kumar-improving · 2025-10-24T00:38:52Z

Issue link

This Pull Request is linked to issue (URL): valkey-io/valkey-glide#4588

Checklist

Before submitting the PR make sure the following are checked:

This Pull Request is related to one issue.
Commit message has a detailed description of what changed and why.
Tests are added or updated.
CHANGELOG.md and documentation files are updated.
Destination branch is correct - main or release
Create merge commit if merging release branch into main, squash otherwise.

Signed-off-by: Prateek Kumar <[email protected]>

Signed-off-by: prateek-kumar-improving <[email protected]>

Signed-off-by: Prateek Kumar <[email protected]>

…emoving printf statements Signed-off-by: Prateek Kumar <[email protected]>

Signed-off-by: Prateek Kumar <[email protected]>

logger.h

Signed-off-by: Prateek Kumar <[email protected]>

logger.h

Signed-off-by: Prateek Kumar <[email protected]>

Signed-off-by: James Duong <[email protected]>

prateek-kumar-improving added 2 commits October 23, 2025 17:37

PHP: Add logging

c3185a4

Signed-off-by: Prateek Kumar <[email protected]>

Merge branch 'main' into php/add-logging

8000670

Signed-off-by: prateek-kumar-improving <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 24, 2025 00:39 — with GitHub Actions Error

prateek-kumar-improving requested a review from jduo October 24, 2025 00:40

PHP: Fix formatting issue

e2d48bc

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 27, 2025 06:25 — with GitHub Actions Error

PHP: Add error logs

3821a7c

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 27, 2025 06:38 — with GitHub Actions Error

PHP: Remove printf statements

fd7f175

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 27, 2025 07:10 — with GitHub Actions Error

prateek-kumar-improving marked this pull request as ready for review October 27, 2025 07:11

prateek-kumar-improving requested a review from yipin-chen October 27, 2025 07:11

PHP: Remove printf statements

e8bd63b

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 27, 2025 07:23 — with GitHub Actions Error

PHP: Update logs

faf9c60

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 27, 2025 08:47 — with GitHub Actions Error

PHP: Update logs

4b273ff

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 27, 2025 08:51 — with GitHub Actions Error

PHP: Update logs

7b68269

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 27, 2025 16:52 — with GitHub Actions Error

PHP: Update logs

d23416e

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 27, 2025 17:10 — with GitHub Actions Error

PHP: Update logs

602de53

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 28, 2025 01:50 — with GitHub Actions Error

PHP: Update logs

224e87a

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 28, 2025 07:54 — with GitHub Actions Error

PHP: Update logs

da3a9e8

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 28, 2025 08:06 — with GitHub Actions Error

PHP: Update logs

11afa59

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 28, 2025 08:09 — with GitHub Actions Error

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 31, 2025 16:16 — with GitHub Actions Error

PHP: Test added

9f73223

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 31, 2025 16:39 — with GitHub Actions Error

PHP: Update logs

f3b7151

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 31, 2025 17:23 — with GitHub Actions Error

PHP: Update debug log in valkey_glide_core_common.c

16eb389

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving requested a deployment to AWS_ACTIONS October 31, 2025 17:31 — with GitHub Actions In progress

PHP: update DEBUG_VALKEY_GLIDE_PHP in valkey_glide_core_common.c by r…

80a7101

…emoving printf statements Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 31, 2025 17:38 — with GitHub Actions Error

PHP: format file valkey_glide_core_common.c

8bf0fa1

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 31, 2025 17:44 — with GitHub Actions Error

jduo reviewed Oct 31, 2025

View reviewed changes

logger.h Outdated Show resolved Hide resolved

PHP: Updated log level check in logger.h macros

34dd282

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 31, 2025 18:06 — with GitHub Actions Error

PHP: Format file logger.h

7ff5baf

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 31, 2025 18:07 — with GitHub Actions Error

jduo reviewed Oct 31, 2025

View reviewed changes

logger.h Outdated Show resolved Hide resolved

jduo reviewed Oct 31, 2025

View reviewed changes

logger.h Outdated Show resolved Hide resolved

jduo reviewed Oct 31, 2025

View reviewed changes

logger.h Outdated Show resolved Hide resolved

PHP: Update macros in logger.h

7674b8f

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 31, 2025 18:28 — with GitHub Actions Error

PHP: Macros in logger.h updated with error logs

25e3286

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 31, 2025 18:32 — with GitHub Actions Error

PHP: Common macro added in logger.h

a8f89f0

Signed-off-by: Prateek Kumar <[email protected]>

prateek-kumar-improving had a problem deploying to AWS_ACTIONS October 31, 2025 18:51 — with GitHub Actions Error

jduo approved these changes Oct 31, 2025

View reviewed changes

yipin-chen approved these changes Oct 31, 2025

View reviewed changes

Merge branch 'main' into php/add-logging

2f4ccce

Signed-off-by: James Duong <[email protected]>

jduo requested a deployment to AWS_ACTIONS October 31, 2025 20:29 — with GitHub Actions Queued

prateek-kumar-improving merged commit 13de2c8 into main Oct 31, 2025
25 of 26 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

PHP: Add logging #68

PHP: Add logging #68

Uh oh!

prateek-kumar-improving commented Oct 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PHP: Add logging #68

PHP: Add logging #68

Uh oh!

Conversation

prateek-kumar-improving commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue link

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

prateek-kumar-improving commented Oct 24, 2025 •

edited

Loading