fix(deps): unblock test suite after vitest 4 + pytest 9 bumps#6
Merged
Conversation
Two regressions surfaced once dependabot's npm and pip bumps landed on
main alongside the credential-grid PR:
1. packages/core/tests/kdf.test.ts used the trailing-options form
`describe(name, fn, opts)` which vitest 3 deprecated and vitest 4
removed. Move the `{ timeout: 30_000 }` to the second positional arg
per the new signature. 25/26 vitest tests pass again (1 skipped is
the network-bound integration suite).
2. server/pyproject.toml pinned `pytest-asyncio==0.24.0`, which caps at
pytest<8.4 and so refused to install alongside `pytest==9.0.3` from
the dependabot bump. The 1.x line is the first that supports
pytest 9 — bump to `pytest-asyncio==1.3.0`. 32/32 pytest tests pass
with 83% coverage restored.
Lockfile drift: npm tightened the `vitest` constraint from `^4.1.5` to
the exact version after `npm install`; included so the committed
lockfile matches the resolver's canonical output.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two regressions surfaced when dependabot's npm and pip bumps landed on main alongside #5. Each was green in its own PR's CI; together they aren't.
What broke
vitest 4 removed the trailing-options form.
packages/core/tests/kdf.test.tsuseddescribe(name, fn, { timeout: 30_000 }), which vitest 3 deprecated and vitest 4 removed. Result: the suite refused to load withTypeError: Signature \"test(name, fn, { ... })\" was deprecated in Vitest 3 and removed in Vitest 4.pytest-asyncio==0.24.0is capped atpytest<8.4. Oncepytest==9.0.3landed,pip install -e \".[dev]\"failed withResolutionImpossible, which in turn causedpytestto fail at conftest import (No module named 'passman').What changed
packages/core/tests/kdf.test.ts— move{ timeout: 30_000 }to the second positional arg (describe(name, opts, fn)).server/pyproject.toml— bumppytest-asyncio==0.24.0 → 1.3.0(first line that supports pytest 9). Comment explains the cap so a future reader doesn't downgrade by reflex.package-lock.json— minor drift: npm tightened thevitestconstraint from^4.1.5to the exact version afternpm install. Included so the lockfile matches the resolver's canonical output.Verification
npm test --workspaces --if-present— 25 passed, 1 skipped in core; web--passWithNoTestsclean.npm run typecheck --workspaces --if-present— clean across core, web, extension.npm run build --workspace=@passman/core— clean.npm run build --workspace=@passman/web— clean (vite build).cd server && pytest -q— 32 passed, 83.45% coverage (above 80% gate).🤖 Generated with Claude Code