Skip to content

Conversation

brucruz
Copy link

@brucruz brucruz commented May 9, 2025

  • Moved @Retry decorator to a separate fetch_with_response() function
  • Prevented retries from duplicating bot replies on failure
  • Improved error handling for JSON parsing and Wit.AI response

brucruz added 3 commits May 8, 2025 21:42
- Moved @Retry decorator to a separate fetch_with_response() function
- Prevented retries from duplicating bot replies on failure
- Improved error handling for JSON parsing and Wit.AI response
- Moved @Retry decorator to a separate fetch_with_response() function
- Prevented retries from duplicating bot replies on failure
- Improved error handling for JSON parsing and Wit.AI response
Copy link
Member

@Logerfo Logerfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes don't fix the duplication issue, as it's probably being caused by an architecture flaw. Regardless of that, I think they make the code a little better, so I'm willing to accept it, as long as we keep the comments.

Comment on lines -22 to -23
#?v=20221114
#&context=%7B%22locale%22%3A%22pt_BR%22%7D
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate having those comments, although the code is currently not being used, it provides useful context in case we need to provide those parameters to the vendor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants