Skip to content

Add support for struct aliases completition #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add support for struct aliases completition #327

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1dc8c5a
Add support for struct aliases completition in completionengine.vala
edwood-grant Sep 23, 2025
f1214b9
Avoid completion on base struct constants, creation methods and stati…
edwood-grant Sep 24, 2025
4fc623f
Merge branch 'master' into struct-alias-code-complete-300
edwood-grant Oct 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/codehelp/completionengine.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,6 +1033,11 @@ namespace Vls.CompletionEngine {
in_oce,
is_cm_this_or_base_access))
continue;
// Avoid base struct creation and static methods
if (((method_sym is Vala.CreationMethod) || method_sym.binding == Vala.MemberBinding.STATIC)) {
if (current_scope.owner.name != null && current_scope.owner.name != struct_sym.scope.owner.name)
continue;
}
var completion = new CompletionItem.from_symbol (type, method_sym, current_scope, CompletionItemKind.Method, lang_serv.get_symbol_documentation (project, method_sym));
completion.insertText = generate_insert_text_for_callable (type, method_sym, current_scope, method_spaces);
completion.insertTextFormat = InsertTextFormat.Snippet;
Expand All @@ -1050,9 +1055,18 @@ namespace Vls.CompletionEngine {
foreach (var constant_sym in struct_sym.get_constants ()) {
if (!CodeHelp.is_symbol_accessible (constant_sym, current_scope))
continue;
// Avoid base struct constants
if (current_scope.owner.name != null && current_scope.owner.name != struct_sym.scope.owner.name)
continue;
completions.add (new CompletionItem.from_symbol (type, constant_sym, current_scope, CompletionItemKind.Constant, lang_serv.get_symbol_documentation (project, constant_sym)));
}
}

// get instance members of base_struct
if (struct_sym.base_struct != null) {
add_completions_for_type (lang_serv, project, code_style, type, struct_sym.base_struct,
completions, struct_sym.scope, in_oce, false, seen_props, seen_type_symbols);
}
} else if (type_symbol is Vala.TypeParameter) {
var typeparam_sym = (Vala.TypeParameter) type_symbol;
var generic_type = new Vala.GenericType (typeparam_sym);
Expand Down