Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support VSCode Meson plugin #305

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Support VSCode Meson plugin #305

wants to merge 4 commits into from

Conversation

PterX
Copy link

@PterX PterX commented Jan 31, 2024

No description provided.

lw64
lw64 requested changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@lw64 lw64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and nice improvement!

src/projects/mesonproject.vala Outdated Show resolved Hide resolved
src/projects/mesonproject.vala Outdated Show resolved Hide resolved
src/projects/mesonproject.vala Outdated Show resolved Hide resolved
src/projects/mesonproject.vala Outdated Show resolved Hide resolved
src/projects/mesonproject.vala Outdated Show resolved Hide resolved
src/projects/mesonproject.vala Outdated Show resolved Hide resolved
src/projects/mesonproject.vala Outdated Show resolved Hide resolved
@PterX PterX requested a review from lw64 February 1, 2024 15:49
@PterX
Copy link
Author

PterX commented Feb 21, 2024 •
edited
Loading

Are there any other problems? Can they be merged? @lw64

@lw64 lw64 requested a review from Prince781 February 21, 2024 14:51
@PterX
Copy link
Author

PterX commented Feb 25, 2024

@Prince781

Prince781
Prince781 reviewed Mar 30, 2024
View reviewed changes
Copy link
Member

@Prince781 Prince781 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is for supporting VSCode, it should be in the vala-vscode plugin. We don't want to use VSCode settings unless we're actually running the language server through VSCode.

src/projects/mesonproject.vala Outdated Show resolved Hide resolved
src/projects/mesonproject.vala Outdated Show resolved Hide resolved
src/projects/mesonproject.vala Outdated Show resolved Hide resolved
src/projects/mesonproject.vala Outdated Show resolved Hide resolved
src/projects/mesonproject.vala Outdated Show resolved Hide resolved
src/projects/mesonproject.vala Outdated Show resolved Hide resolved
@Prince781 Prince781 changed the title add meson args and env support Support VSCode Meson plugin Mar 30, 2024
Prince781 added a commit that referenced this pull request Apr 1, 2024
@Prince781
meson: support settings overrides from editor
f1fb3ff 
This introduces settings overrides (`EditorOptions`) passed from the
editor to the server in the initialize() call. These overrides are just
currently for the Meson backend. The intent is to have the vala-vscode
extension send these options from the Meson VSCode extension to VLS.

Closes #304 and #305.
@Prince781 Prince781 mentioned this pull request Apr 1, 2024
Open
@Prince781
Copy link
Member

@PterX I have what I believe is a better approach: let the server override its settings if the editor passes this information to it. Make the Vala VSCode extension get this information from the Meson extension, if it is installed. See #306

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prince781 Prince781 Prince781 left review comments

@lw64 lw64 lw64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PterX @Prince781 @lw64