feat: iDontWant is sent only for gossipsub 1.2 or higher #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlejandroCabeza
approved these changes
Jun 24, 2024
My implementation is wrong, it should be sent for versions >= 1.2. |
diegomrsantos
changed the title
diegomrsantos
force-pushed
the
gossipsub12-improv
branch
from
50ed800 to
55a6eb1
Compare
lchenut
reviewed
Jun 25, 2024
tests/pubsub/testgossipsub.nim
Outdated
| discard | ||
|
|
||
| proc handlerB(topic: string, data: seq[byte]) {.async.} = | ||
| echo "handlerB ", topic, data.len |
There was a problem hiding this comment.
I'm not a fan of leaving echo in tests. It might be interesting to replace it with a check, though.
There was a problem hiding this comment.
oh thanks, I forgot it there.
lchenut
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1131