Skip to content

test: add visual tests for date-picker base styles #9018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

web-padawan
Copy link
Member

Description

Added some visual tests covering vaadin-date-picker base styles.

Type of change

  • Test

@web-padawan web-padawan requested a review from vursen April 28, 2025 13:56
@web-padawan web-padawan force-pushed the test/base-date-picker branch from d18dae3 to a3cfb18 Compare April 28, 2025 14:03
@web-padawan
Copy link
Member Author

RTL dropdown tests look wrong to me (specifically the selected year arrow indicator). I'll look into fixing that.

@web-padawan
Copy link
Member Author

Created #9019 with some fixes, will update this PR once that one is merged.

@web-padawan web-padawan force-pushed the test/base-date-picker branch from a3cfb18 to 03853e9 Compare April 29, 2025 08:30
@web-padawan web-padawan merged commit 8ffcf7e into base-styles Apr 29, 2025
8 checks passed
@web-padawan web-padawan deleted the test/base-date-picker branch April 29, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants