-
Notifications
You must be signed in to change notification settings - Fork 65
fix(engine-core): always consume Process output #3913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3913 +/- ##
=======================================
Coverage 86.29% 86.29%
=======================================
Files 123 123
Lines 8485 8485
Branches 1302 1302
=======================================
Hits 7322 7322
Misses 1140 1140
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests seems to run forever, meaning that something keeps waiting.
// Consume all output from Node | ||
var lines = new BufferedReader( | ||
new InputStreamReader(stdOutStream)).lines().toList(); | ||
lines.stream().limit(1).forEach(pathLine::set); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What has changed here exactly?
Luciano Vernaschi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Fixes #3696