-
Notifications
You must be signed in to change notification settings - Fork 187
feat: allow skipping Vaadin maven plugin execution during a build #22516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow skipping Vaadin maven plugin execution during a build #22516
Conversation
- Added skip parameter to FlowModeAbstractMojo with property "vaadin.skip" - Added early return in execute() method when skip=true - Added informative log message when skipping - Created integration test and unit test for skip functionality - Parameter can be used with: mvn clean install -Dvaadin.skip 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of preliminary comments.
About the vaadin-skip-test
integration test for the maven plugin, it would be good to add a verify.bsh file that checks the build output to ensure the plugin execution has been skipped. You can take a look at the offending-dependency-project
test for inspiration.
...ugins/flow-maven-plugin/src/main/java/com/vaadin/flow/plugin/maven/FlowModeAbstractMojo.java
Outdated
Show resolved
Hide resolved
8e709d7
to
e7eaa41
Compare
Not sure what to make of all these build errors, but locally the build passes with tests and integration tests now. |
No further actions for you at the moment. Builds must be restarted after code review by a Vaadin team member. BTW, thanks for the contribution! |
flow-plugins/flow-maven-plugin/src/it/vaadin-skip-test/invoker.properties
Outdated
Show resolved
Hide resolved
Trying to run spotless to fix formatting errors gives this:
|
Works for me. Weird error. |
@jorgheymans are you using |
Indeed,
|
|
… plugin. (#4664) depends on vaadin/flow#22516 Co-authored-by: Mikhail Shabarov <[email protected]>
Description
It can be sometimes desirable to skip the execution of the Vaadin maven plugin, for example when running the project unit tests from the command line, to speed up the project build.
Fixes #21426
Type of change
Checklist
Additional for
Feature
type of change