Refactor MutableTreeRevision #21000
Open
Refactor MutableTreeRevision #21000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Legioth
commented
Feb 14, 2025
Legioth
commented
- Rename TreeManipulator to ResultBuilder and use it only for multi-step commands and commands that affect multiple nodes
- Explicitly return a result when handling a command instead of indirectly producing one
- Transactions produce multiple results so they have custom top-level handling instead of following the general pattern
- Handle errors caused by concurrent modifications by returning a Reject result instead of passing the error through an instance field
* Rename TreeManipulator to ResultBuilder and use it only for multi-step commands and commands that affect multiple nodes * Explicitly return a result when handling a command instead of indirectly producing one * Transactions produce multiple results so they have custom top-level handling instead of following the general pattern * Handle errors caused by concurrent modifications by returning a Reject result instead of passing the error through an instance field
taefi
reviewed
Apr 24, 2025
signals/src/main/java/com/vaadin/signals/impl/MutableTreeRevision.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.