Binder.validate() no longer fails with "bean level validators have been configured but no bean is currently set" when in buffered mode #18121

mvysny · 2023-11-24T07:34:21Z

Description

This PR makes the Binder.validate() implementation in line with its javadoc. Namely, Binder.validate() no longer fails with "bean level validators have been configured but no bean is currently set" when in buffered mode, which is according to the current javadoc: "Bean level validators are ignored if there is no bound bean or if any field level validator fails."

Fixes #18120

Type of change

Bugfix
Feature

Checklist

I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
I have added a description following the guideline.
The issue is created in the corresponding repository and I have referenced it.
I have added tests to ensure my change is effective and works as intended.
New and existing tests are passing locally with my change.
I have performed self-review and corrected misspellings.

Additional for `Feature` type of change

Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

…el validations are defined. Fixes #18120

…s() to perform explicit checks

github-actions · 2023-11-24T07:48:34Z

Test Results

1 192 files ± 0 1 192 suites ±0 1h 16m 58s ⏱️ + 1m 1s
8 320 tests ± 0 8 263 ✅ ± 0 57 💤 ±0 0 ❌ ±0
8 655 runs - 36 8 589 ✅ - 36 66 💤 ±0 0 ❌ ±0

Results for commit 4520b60. ± Comparison against base commit 5ab4dc0.

This pull request removes 3 and adds 3 tests. Note that renamed tests count towards both.

com.vaadin.flow.data.binder.BinderTest ‑ beanvalidation_isValid_throws_with_readBean
com.vaadin.flow.data.binder.BinderTest ‑ beanvalidation_validate_throws_with_readBean
com.vaadin.flow.data.binder.BinderTest ‑ isValidTest_unbound_binder_throws_with_bean_level_validation

com.vaadin.flow.data.binder.BinderTest ‑ beanvalidation_isValid_passes_with_readBean
com.vaadin.flow.data.binder.BinderTest ‑ beanvalidation_validate_passes_with_readBean
com.vaadin.flow.data.binder.BinderTest ‑ isValidTest_unbound_binder_passes_with_bean_level_validation

♻️ This comment has been updated with latest results.