Skip to content

Commit

Permalink
Small improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
nilproject committed Mar 22, 2017
1 parent 6114309 commit 8d4b5db
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 10 deletions.
30 changes: 21 additions & 9 deletions FunctionalTests/OverloadedMethods.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,20 @@ public sealed class OverloadedMethods
{
private class Class
{
public void Method()
{ }
public int Method()
{
return 0;
}

public void Method(int a, int b)
{ }
public int Method(int a, int b)
{
return 2;
}

public void Method(int a)
{ }
public int Method(int a)
{
return 1;
}
}

[TestMethod]
Expand All @@ -30,7 +36,9 @@ public void OverloadedMethods_0()
var instance = new Class();

context.DefineVariable($"{nameof(instance)}").Assign(JSValue.Marshal(instance));
context.Eval($"{nameof(instance)}.{nameof(instance.Method)}()");
var result = context.Eval($"{nameof(instance)}.{nameof(instance.Method)}()");

Assert.AreEqual(0, result.Value);
}

[TestMethod]
Expand All @@ -40,7 +48,9 @@ public void OverloadedMethods_1()
var instance = new Class();

context.DefineVariable($"{nameof(instance)}").Assign(JSValue.Marshal(instance));
context.Eval($"{nameof(instance)}.{nameof(instance.Method)}(1)");
var result = context.Eval($"{nameof(instance)}.{nameof(instance.Method)}(1)");

Assert.AreEqual(1, result.Value);
}

[TestMethod]
Expand All @@ -50,7 +60,9 @@ public void OverloadedMethods_2()
var instance = new Class();

context.DefineVariable($"{nameof(instance)}").Assign(JSValue.Marshal(instance));
context.Eval($"{nameof(instance)}.{nameof(instance.Method)}(1, 2)");
var result = context.Eval($"{nameof(instance)}.{nameof(instance.Method)}(1, 2)");

Assert.AreEqual(2, result.Value);
}
}
}
1 change: 0 additions & 1 deletion NiL.JS.NetCore/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
"dependencies": {
"NETStandard.Library": "1.3.0",
"System.Dynamic.Runtime": "4.0.11",
"System.Linq": "4.1.0",
"System.Reflection.TypeExtensions": "4.1.0",
"System.Resources.ResourceManager": "4.0.1",
"System.Runtime": "4.1.0"
Expand Down

0 comments on commit 8d4b5db

Please sign in to comment.