src: gpu: intel: jit: clarify the naming for kernel/thread grids #2792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
platform:gpu-intel
hidefromkgb
force-pushed
the
aguskov/jit_ir_kg_tg_refactor
branch
from
25cd603 to
599ff32
Compare
syurkevi
approved these changes
Mar 4, 2025
echeresh
approved these changes
Mar 4, 2025
hidefromkgb
force-pushed
the
aguskov/jit_ir_kg_tg_refactor
branch
from
fa46623 to
59cd4b6
Compare
hidefromkgb
commented
Mar 7, 2025
echeresh
reviewed
Mar 7, 2025
| pvar_tile_t inner; | ||
| for (auto &d : conv_index_dims(cfg.prb().prop_kind())) { | ||
| dim_t iter = cfg.iter_dim(d); | ||
| dim_t tg = cfg.thread_group_dim(d); | ||
| dim_t thr = cfg.thread_dim(d); |
There was a problem hiding this comment.
I think tg = cfg.thread_dim(d); still works (tg - thread group size).
There was a problem hiding this comment.
I still think it's thr, but yes, П(thr) = tg_size — whereas П(tg) = tg_count.
hidefromkgb
force-pushed
the
aguskov/jit_ir_kg_tg_refactor
branch
2 times, most recently
from
2764315 to
a78420c
Compare
|
make test |
hidefromkgb
force-pushed
the
aguskov/jit_ir_kg_tg_refactor
branch
from
a78420c to
edec79e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the kernel / threadgroup terminological mixup in the jit:ir generator.