-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xe: ocl: add inline load #2661
xe: ocl: add inline load #2661
Conversation
7ca5242
to
1768064
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I didn't think we were this close to being able to get rid of type punning in our ocl kernels. What are the remaining roadblocks for the other kernels? I know there are issues with vector operations (not yet supported on the custom types), and I think the dispatcher has some constraints?
I messed around with that some as well, check out the branch |
1768064
to
55b11a2
Compare
Adds a new load function overload to remove the need for variable pre-declaration before loading.
55b11a2
to
4719b1b
Compare
make test |
Adds a new load function overload to remove the need for variable pre-declaration before loading. In addition, refactors a few reference kernels (ref_bnorm, ref_eltwise, ref_lrn) to use ocl_io.h to demonstrate the utility.