Build acl cache sequentially #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryo-not-rio
force-pushed
the
fix-cache-up
branch
7 times, most recently
from
76f8c25 to
6b22724
Compare
| cmake --build $ACL_ROOT_DIR/build | ||
| cd $ACL_ROOT_DIR | ||
| set -x | ||
| scons $MP Werror=0 debug=$ACL_DEBUG neon=1 opencl=0 embed_kernels=0 \ |
There was a problem hiding this comment.
Did CMake not work at all? It is surprising that it was building fine before.
There was a problem hiding this comment.
No, wasn't working for gcc or macOS, I imagine you hadn't changed ACL versions after switching to cmake so we were always reusing the cached build
theComputeKid
requested changes
Jan 17, 2025
|
Looks good. Just need to squash commits. |
.github/workflows/aarch64-acl.yml
Outdated
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
| paths: | ||
| - '.github/automation/ci-aarch64.json' |
There was a problem hiding this comment.
Will this work correctly when we update ACL in a PR and the ci-aarch64.yml runs at the same time as the aarch64-acl.yml? Should ci-aarch64.yml not depend on aarch64-acl.yml finishing first?
There was a problem hiding this comment.
I've changed this workflow to a reusable workflow so this problem should be solved
Ryo-not-rio
force-pushed
the
fix-cache-up
branch
2 times, most recently
from
fdc09ca to
b363eb5
Compare
theComputeKid
approved these changes
Jan 21, 2025
theComputeKid
requested changes
Jan 21, 2025
Ryo-not-rio
force-pushed
the
fix-cache-up
branch
from
b363eb5 to
2e21af9
Compare
theComputeKid
approved these changes
Jan 21, 2025
Ryo-not-rio
added a commit
to Ryo-not-rio/oneDNN
that referenced
this pull request
Jan 27, 2025
The aarch64 nightly ci is failing due to a recent change in uxlfoundation#2388 where the ACL caching mechanism was changed. This updates the nightly pipeline to use the new caching system
theComputeKid
pushed a commit
that referenced
this pull request
Jan 28, 2025
The aarch64 nightly ci is failing due to a recent change in #2388 where the ACL caching mechanism was changed. This updates the nightly pipeline to use the new caching system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using github actions caches with the matrix strategy, the
cache-hitvariable is shared amongst all the strategies, potentially causing a race condition when run in parallel. This work creates just the caches sequentially, avoiding this problem