-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] remove vestigial Python code and define dependency for oneDAL make builds #2929
base: main
Are you sure you want to change the base?
Conversation
/intelci: run |
INSTALL.md
Outdated
@@ -22,6 +22,7 @@ Required Software: | |||
* [DPC++ Compiler](https://www.intel.com/content/www/us/en/developer/tools/oneapi/dpc-compiler.html) | |||
* Microsoft Visual Studio\* (Windows\* only) | |||
* [MSYS2](http://msys2.github.io) (Windows\* only) | |||
* Python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a line about it in the current master branch, two lines above where this would be inserted:
https://github.com/oneapi-src/oneDAL/blob/66f4858285c229a44be2ab17843edcbafaa989b9/INSTALL.md?plain=1#L23
It does mention "3.9" though so I guess there's no need to forego f-strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for clarity, the mentioning of 3.9 was just introduced in your PR #2923 just after this PR was submitted (hence why I was confused). 3.9 requirement is set from here #2923 (comment) . I will rebase this PR to reflect your changes.
The only python script that is run for make install is this python file and is the source of the dependency. We do not test python consistently in any of our build steps. The private CI uses 3.12 as defined by infrastructure. The Ubuntu 24.04 docker runners use 3.12. The azure pipelines runners are also using default Ubuntu 22.04 python (3.10) runners. We do not test 3.9 nor 3.11 for oneDAL building.
Thus by changing these f-strings, we can support Ubuntu 20+ default python (i.e. python 2.7+).
@napetrov is there a reason why on build-side for oneDAL there is this python requirement?
I have removed vestigial code from the codebase which does not get run in any CI step any longer. |
Move back to draft because sklearn conformance in this repo absolutely needs to be updated. On the border of disappointing. |
/azp run CI |
Azure Pipelines successfully started running 1 pipeline(s). |
Description
Building on older ubuntu versions fail due to
deploy/generate_pkgconfig.py
being Python 3.6+ dependent. This was not standard until Ubuntu 22. These changes make it buildable on Ubuntu versions which maintain a python version (not explicitly Python3). Requiring Python is not included in the INSTALL.md, is set but without a version.NOTE: All scripts under
.ci/scripts/conformance-scripts/
are vestigial, and can be removed. (Are done so in this PR).Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance