[oneDPL] Indirectly Device Accessible Iterator Customization Point and Public Trait#620
Merged
danhoeflinger merged 60 commits intomainfrom May 5, 2025
Merged
[oneDPL] Indirectly Device Accessible Iterator Customization Point and Public Trait#620danhoeflinger merged 60 commits intomainfrom
danhoeflinger merged 60 commits intomainfrom
Conversation
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
danhoeflinger
commented
Apr 3, 2025
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
danhoeflinger
changed the title
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
akukanov
reviewed
Apr 4, 2025
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Co-authored-by: Alexey Kukanov <[email protected]>
Contributor
Author
|
@akukanov All good suggestions... applied. Thanks. |
akukanov
reviewed
May 1, 2025
akukanov
reviewed
May 1, 2025
Co-authored-by: Alexey Kukanov <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
mmichel11
reviewed
May 1, 2025
mmichel11
left a comment
mmichel11
left a comment
There was a problem hiding this comment.
I have some small suggestions after rereading the latest version. I am ready to approve once these are considered.
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
…edge Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
akukanov
reviewed
May 1, 2025
Co-authored-by: Alexey Kukanov <[email protected]>
akukanov
reviewed
May 5, 2025
Contributor
There was a problem hiding this comment.
Below are some formatting comments, after inspecting the rendered HTML page.
Also, to me it seems excessive to italicize every occurrence of the new terms. In principle, it's enough to do once when the term is introduced; see https://oneapi-spec.uxlfoundation.org/specifications/oneapi/v1.4-rev-1/elements/onedpl/source/parallel_api/buffer_wrappers as an example for buffer position objects. I think it is OK to highlight it sometimes again, when the term is sort of reintroduced (perhaps with a link to the original definition).
Co-authored-by: Alexey Kukanov <[email protected]>
Signed-off-by: Dan Hoeflinger <[email protected]>
akukanov
approved these changes
May 5, 2025
rarutyun
reviewed
May 5, 2025
| template <typename T> | ||
| inline constexpr bool is_indirectly_device_accessible_v = is_indirectly_device_accessible<T>::value; | ||
|
|
||
| ``template <typename T> oneapi::dpl::is_indirectly_device_accessible`` is a type which has the base characteristic |
Contributor
There was a problem hiding this comment.
I would suggest to use "class template" or just "template" instead of type, because is_indirectly_device_accessible is not a "type"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specification for "indirectly device accessible iterator" customization point and public trait. Based upon proposed [RFC].(uxlfoundation/oneDPL#1999)