Redesign dictionary id use, add columnFromValues. #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR redesigns how dictionary ids are used.
dictionary()
type constructor will set the id to a default value of -1 if not specified.tableFromIPC
.tableToIPC
. This effective serialization of tables that may have been built with conflicting dictionary ids.dictionaryTypes
map from schema objects, as it is no longer needed. This also simplifies some of the decoding code.In addition, this PR adds a new builder method that allows values to be provided by a visitor function:
columnFromValues
method. Instead of providing a materialized array, callers can provide a total length and a visit (or "scan") function that invokes a callback with each successive value.