Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten table expression type signature. #374

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Tighten table expression type signature. #374

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba1bcef
fix: Tighten table expression type signature.
jheer Oct 4, 2024
4905895
fix: Further tighten expr func type.
jheer Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/table/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,13 +165,13 @@ export type TableExprString = string | Stringable;
export type Struct = Record<string, any>;

/** A function defined over a table row. */
export type TableExprFunc = (d?: Struct, $?: Params) => any;
export type TableExprFunc = (d: Struct, $: Params) => any;

/** A table expression defined over a single table. */
export type TableExpr = TableExprFunc | TableExprString;

/** A function defined over rows from two tables. */
export type TableExprFunc2 = (a?: Struct, b?: Struct, $?: Params) => any;
export type TableExprFunc2 = (a: Struct, b: Struct, $: Params) => any;

/** A table expression defined over two tables. */
export type TableExpr2 = TableExprFunc2 | TableExprString;
Expand Down