Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit Login/Signup with Enter Key #211

Closed
wants to merge 2 commits into from

Conversation

owen-sellner
Copy link
Contributor

Notion task link

N/A

Implementation description

  • Added HTML form tag to Login.tsx and Signup.tsx

Steps to test

  1. Create a new user
  2. Verify that Login and Signup submit when the enter key is pressed

What should reviewers focus on?

  • Should their be some feedback given to the user when they submit this way? (Normally the button changes when clicked)

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
  • If I have made API changes, I have updated the REST API Docs
  • IF I have made changes to the db/models, I have updated the Data Models Page
  • I have documented this PR in the Production Release Page
  • I have updated other Docs as needed

Copy link

github-actions bot commented Nov 29, 2023

Visit the preview URL for this PR (updated for commit 17e443a):

https://blueprintsupportivehousing--pr211-owen-login-signup-su-t14z78tr.web.app

(expires Thu, 01 Feb 2024 03:16:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f6bcdba7452bf82a6ec1a299c37d1bdff7870d09

@@ -69,7 +69,9 @@ const Login = ({
setPasswordErrStr("");
};

const onLogInClick = async () => {
const onLogInClick = async (e: React.FormEvent<HTMLFormElement>) => {
e.preventDefault();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥶

@connor-bechthold
Copy link
Collaborator

connor-bechthold commented Jan 25, 2024

Closing for now to clear remaining PRs -> will test if requested (thank you for cooking this up Owen 🙏 ). I think there MAY be some merge issues created since the last time 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants