-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resident Status Style #210
Conversation
Visit the preview URL for this PR (updated for commit 50cfd6b): https://blueprintsupportivehousing--pr210-owen-resident-status-8ysuqk7k.web.app (expires Sun, 10 Dec 2023 21:10:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f6bcdba7452bf82a6ec1a299c37d1bdff7870d09 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With these bubbles I think it looks better if it's centered in the column similar to how it's done in the Employee Directory
Also, there's a bug if you set the end date to the same date as the current date - it shows Past
instead of Current
. I believe this has to do with the fact that the new Date()
you're making has hours associated with it; if you set the hours, minutes, and seconds, to 0 it should fix this.
Colours on the status looks great tho, frontend god strikes again 💯
frontend/src/components/pages/ResidentDirectory/ResidentDirectoryTable.tsx
Show resolved
Hide resolved
status = ResidentStatus.PAST; | ||
} | ||
} | ||
if (currentDate < startDateObj) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could make this an else if lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm alpha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Notion task link
N/A
Implementation description
ResidentTypes.ts
to ensure status string values are consistantResidentDirectoryTable.tsx
to include "Future" as a statusResidentDirectoryTable.tsx
to convert the status to colorSteps to test
create-residents.sh
)What should reviewers focus on?
Screenshot
Checklist