[BUG] Pagination Total Num of Pages Fix

[kevin-pierce]

Notion task link

No Associated Task

This ticket aims to resolve an issue occurring on any page leveraging the Pagination component, in which an error state in the component will briefly be flashed since the total num of pages at that point is initially set to 0, while the user's page number is by default 1 (thus we end up displaying Page 1 of 0, leading to the error state temporarily). This fix resolves that issue.

Implementation description

• The denominator of the page (numPages) is calculated using the current num of records ; on page load, this will be 0 (as we are still fetching the number of records), and so we want to simply set this to be the max of each value (1 and numRecords) so that when records are loading, we see Page X of 1

Steps to test

1. Verify for log records, residents, and the employee page that the error state on the pagination component does NOT appear (and that initially we just see page 1 of 1)

What should reviewers focus on?

Checklist

• My PR name is descriptive and in imperative tense
• My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
• I have run the appropriate linter(s)
• I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
• If I have made API changes, I have updated the REST API Docs
• IF I have made changes to the db/models, I have updated the Data Models Page
• I have documented this PR in the Production Release Page
• I have updated other Docs as needed

[github-actions]

Visit the preview URL for this PR (updated for commit 18f477c):

https://blueprintsupportivehousing--pr209-kevin-page-num-bugfi-m6c6vms8.web.app

_{(expires Sun, 03 Dec 2023 20:42:35 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f6bcdba7452bf82a6ec1a299c37d1bdff7870d09}

[phamkelly17]

niiiiice

[owen-sellner]

LGTM!!! No nits 🙏