-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resident Directory Filter #205
Conversation
Visit the preview URL for this PR (updated for commit 7bb09ea): https://blueprintsupportivehousing--pr205-kelly-resident-direc-x79cmvva.web.app (expires Sat, 06 Jan 2024 03:43:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f6bcdba7452bf82a6ec1a299c37d1bdff7870d09 |
Just wondering, is this the right endpoint url to call when we want to filter by date range but only provide a start date?
|
@braydonwang this is the correct endpoint:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!! I added the one nit that we already talked about.
hour=0, minute=0 | ||
) | ||
|
||
residents_results = Residents.query.join( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably can be moved out of the if-else statements since it is always used.
Notion task link
Resident Directory Filter
Implementation description
resident_id
,building_id
,date_range
Steps to test
What should reviewers focus on?
Checklist