-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verification Page #194
Verification Page #194
Conversation
Visit the preview URL for this PR (updated for commit 4a08a56): https://blueprintsupportivehousing--pr194-owen-verify-2crodrxo.web.app (expires Sun, 10 Dec 2023 21:15:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f6bcdba7452bf82a6ec1a299c37d1bdff7870d09 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you did a really good job on this future pl moment fr
had a couple nits/housekeeping comments to look at but otherwise this is good to go 👨🍳
const location = useLocation(); | ||
const currentPath = location.pathname; | ||
|
||
if (authenticatedUser === null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I think it might be better to check for all possible falsey values here by simply checking for if (!authenticatedUser)
for extra safety
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit, and a more general q about the exception handling for the verification endpoint ; personally I think that the exception stuff would require a bit of an overhaul, and so perhaps it could be broken out into its own ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Notion task link
Login/Signup Verification
Implementation description
AuthenticatedUser
type to include if the user is verified inAuthTypes.tsx
auth_routes.py
is_authorized_by_token
inauth_service.py
to check if a user is verified using the access tokenisVerified
inAuthAPIClient.ts
for the verification page button to update the AuthenticatedUser context if the user becomes verifiedSteps to test
docker exec -it SHOW-database /bin/bash -c "psql -U postgres -d show_db"
insert into users (first_name, last_name, role, user_status, email) values ('your first name', 'your last name', 'Admin', 'Invited', 'your email');
What should reviewers focus on?
Screenshot
Checklist