Log record many residents frontend #189

carolynzhang18 · 2023-11-02T00:02:13Z

Notion task link

Log Record Can Have Many Residents

Implementation description

Frontend: allow user to multiselect residents when creating and editing logs; display multiple residents in record in log records table

Steps to test

Migrate database: bash ./scripts/flask-db-upgrade.sh
Create log: (a) Try making a log with no residents selected - this should give an error. (b) Select multiple residents from the dropdown, play around with adding and removing residents from the selected list. After submitting the new log, you should see all of the residents you selected in the corresponding record in the log records table.
Edit log: When you edit a log, the previously selected residents should be pre-selected for you. Try removing residents and adding residents to the list. After submitting the edited log, you should see your changes in the corresponding record in the log records table.
Delete log

What should reviewers focus on?

Checklist

My PR name is descriptive and in imperative tense
My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
I have run the appropriate linter(s)
I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
If I have made API changes, I have updated the REST API Docs
IF I have made changes to the db/models, I have updated the Data Models Page
I have documented this PR in the Production Release Page
I have updated other Docs as needed

…print/supportive-housing into log-record-many-residents-frontend

…om/uwblueprint/supportive-housing into log-record-many-residents-frontend

into log-record-many-residents-frontend

…om/uwblueprint/supportive-housing into log-record-many-residents-frontend

…print/supportive-housing into log-record-many-residents-frontend

github-actions · 2023-11-05T06:45:15Z

Visit the preview URL for this PR (updated for commit 7432af9):

https://blueprintsupportivehousing--pr189-log-record-many-resi-xw5v4344.web.app

_{(expires Thu, 30 Nov 2023 00:43:46 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f6bcdba7452bf82a6ec1a299c37d1bdff7870d09}

…print/supportive-housing into log-record-many-residents-frontend

This reverts commit 3b03c7f.

…print/supportive-housing into log-record-many-residents-frontend

connor-bechthold

everything looks good - one thing I noticed is with the styling of the dropdown modal for the create/edit:

you'll just have to update the design styling for that box (to match what's done for the employee dropdown there) and you should be good to go!

there's a chance we'll have to slightly modify this once the final designs are in but the changes should be super minimal so this really helps!!

* add invite user script * update README * readme formatting * update readme one last time * update readme one last time

into log-record-many-residents-frontend

connor-bechthold

Few things and then you can merge this in (I'm gonna approve it tho)

Edit log residents dropdown styling
The log records table column name should be changed from Resident to Residents

GREAT WORK WITH THIS!!! The client will love this change 😎

connor-bechthold · 2023-11-22T20:49:02Z

frontend/src/components/forms/EditLog.tsx

-                        (item) => item.label === logRecord.residentId,
+                      onChange={handleResidentsChange}
+                      defaultValue={residentOptions.filter(
+                        (item) => logRecord.residents.includes(item.label),
                      )}


Looks like the styling on this Edit Resident dropdown (you can see its different on the form), so adding styles={selectStyle} should solve this

braydonwang and others added 16 commits October 22, 2023 15:59

initial frontend changes

377f486

Merge branch 'log-record-many-residents' of https://github.com/uwblue…

3c198fa

…print/supportive-housing into log-record-many-residents-frontend

changing create and edit

5b8463b

Enable multiselect for residents

aaa05ce

small fixes

fd59b1d

Enable resident multiselect when creating log

5581997

Merge branch 'log-record-many-residents-frontend' of https://github.c…

6c3eae7

…om/uwblueprint/supportive-housing into log-record-many-residents-frontend

small changes

1afd52c

Fix residents array for API request

33255d3

Merge branch 'log-record-many-residents-frontend' of https://github.c…

1989013

…om/uwblueprint/supportive-housing into log-record-many-residents-frontend

Merge branch 'main' of https://github.com/uwblueprint/supportive-housing

369fca2

into log-record-many-residents-frontend

Merge branch 'log-record-many-residents-frontend' of https://github.c…

c9afb3f

…om/uwblueprint/supportive-housing into log-record-many-residents-frontend

Multiselect residents for edit log

39faf9c

testing some stuff

164a343

Merge branch 'log-record-many-residents-frontend' of https://github.c…

8dbcdd0

…om/uwblueprint/supportive-housing into log-record-many-residents-frontend

fix edit log

4f215de

braydonwang changed the base branch from main to log-record-many-residents November 5, 2023 05:26

Merge branch 'log-record-many-residents' of https://github.com/uwblue…

b425faa

…print/supportive-housing into log-record-many-residents-frontend

braydonwang and others added 11 commits November 5, 2023 14:49

Merge branch 'log-record-many-residents' of https://github.com/uwblue…

0826196

…print/supportive-housing into log-record-many-residents-frontend

Merge branch 'log-record-many-residents' of https://github.com/uwblue…

96c5c8b

…print/supportive-housing into log-record-many-residents-frontend

Merge branch 'log-record-many-residents' of https://github.com/uwblue…

e9aa58b

…print/supportive-housing into log-record-many-residents-frontend

Pass resident labels

3b03c7f

Merge branch 'log-record-many-residents' of https://github.com/uwblue…

dcb7ebf

…print/supportive-housing into log-record-many-residents-frontend

Revert "Pass resident labels"

eeb065e

This reverts commit 3b03c7f.

Merge branch 'log-record-many-residents' of https://github.com/uwblue…

f78c477

…print/supportive-housing into log-record-many-residents-frontend

fix zIndex (#193)

a22ab9d

Merge branch 'log-record-many-residents' of https://github.com/uwblue…

0bd754a

…print/supportive-housing into log-record-many-residents-frontend

run linter

02b8f0c

Merge branch 'log-record-many-residents' of https://github.com/uwblue…

aefae7a

…print/supportive-housing into log-record-many-residents-frontend

connor-bechthold requested changes Nov 12, 2023

View reviewed changes

Connor Bechthold and others added 3 commits November 12, 2023 01:19

Invite user script (#199)

b7ef41d

* add invite user script * update README * readme formatting * update readme one last time * update readme one last time

Merge branch 'main' of https://github.com/uwblueprint/supportive-housing

a25c21d

into log-record-many-residents-frontend

Style residents dropdown

81ab53d

carolynzhang18 requested a review from connor-bechthold November 12, 2023 19:50

connor-bechthold approved these changes Nov 22, 2023

View reviewed changes

Minor style fixes

7432af9

carolynzhang18 merged commit 7432af9 into log-record-many-residents Nov 23, 2023
1 check passed

carolynzhang18 deleted the log-record-many-residents-frontend branch November 23, 2023 00:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Log record many residents frontend #189

Log record many residents frontend #189

carolynzhang18 commented Nov 2, 2023 •

edited by braydonwang

Loading

github-actions bot commented Nov 5, 2023 •

edited

Loading

connor-bechthold left a comment

connor-bechthold left a comment

connor-bechthold Nov 22, 2023

Log record many residents frontend #189

Log record many residents frontend #189

Conversation

carolynzhang18 commented Nov 2, 2023 • edited by braydonwang Loading

Notion task link

Implementation description

Steps to test

What should reviewers focus on?

Checklist

github-actions bot commented Nov 5, 2023 • edited Loading

connor-bechthold left a comment

Choose a reason for hiding this comment

connor-bechthold left a comment

Choose a reason for hiding this comment

connor-bechthold Nov 22, 2023

Choose a reason for hiding this comment

carolynzhang18 commented Nov 2, 2023 •

edited by braydonwang

Loading

github-actions bot commented Nov 5, 2023 •

edited

Loading