Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing slash for typescript and python scrubbing directories #34

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

matthewgeng
Copy link

@matthewgeng matthewgeng commented Mar 5, 2022

Notion ticket link

No ticket. Was originally part of fixing the RM bug, but that was moved to backlog.

Implementation description

  • Removed a trailing slash for the scrubbing of typescript and python directories

Steps to test

  1. Run CLI until reaching the RM bug --> should be no double slash

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
  • I have updated the version number in package.json according to Semantic Versioning specs (semver) if I will be publishing these changes to the npm registry

@matthewgeng matthewgeng requested a review from sherryhli March 5, 2022 20:33
sherryhli
sherryhli previously approved these changes Mar 5, 2022
Copy link
Member

@sherryhli sherryhli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please edit the PR title to something along the lines of "Remove trailing slash in directory names"

@matthewgeng matthewgeng changed the title Mg/fix extra slash Remove trailing slash for typescript and python scrubbing directories Mar 5, 2022
@sherryhli
Copy link
Member

May need to bump package version to 1.0.19 depending on if #33 is merged first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants