Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Search Bar in Announcements Page #89

Merged
merged 3 commits into from
Sep 21, 2024

Conversation

RyanSh3n
Copy link
Contributor

@RyanSh3n RyanSh3n commented Jun 20, 2024

Notion ticket link

Ticket Name

Implementation description

  • Updated search bar to search for rooms
  • Updated announcements rendering to render rooms searched for.

Steps to test

  1. docker compose for front-end

What should reviewers focus on?

  • Front-End UI and functionality (in ./frontend/src/pages/announcements/AnnouncementsGroups.tsx)

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@jeessh jeessh merged commit 2a4e300 into dev Sep 21, 2024
1 check passed
@jeessh jeessh deleted the ryan-kathleen-implement-search-bar-in-announcements-page branch September 21, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants