Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api constants announcements #114

Merged
merged 1 commit into from
Nov 1, 2024
Merged

api constants announcements #114

merged 1 commit into from
Nov 1, 2024

Conversation

KathleenX7
Copy link
Contributor

Notion ticket link

API Constants - Notifications

Implementation description

  • add mutations, queries, and types for notifications
  • add testing in announcements page

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@KathleenX7 KathleenX7 requested a review from jeessh October 19, 2024 15:21
@jeessh jeessh merged commit b15e599 into dev Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeessh jeessh jeessh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KathleenX7 @jeessh