Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

announcement homepage component #104

Merged
merged 6 commits into from
Sep 21, 2024
Merged

announcement homepage component #104

merged 6 commits into from
Sep 21, 2024

Conversation

jeessh
Copy link
Collaborator

@jeessh jeessh commented Aug 20, 2024

Notion ticket link

Create Announcements Component in Homepage

Implementation description

  • Built announcements component for homepage (using mock data)
  • Will need to update when APIs are included

Steps to test

What should reviewers focus on?

  • pages/home/AnnouncementNotification
  • pages/home/HomePage

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@jeessh jeessh requested review from RyanSh3n and ya5er August 20, 2024 13:07
@jeessh jeessh merged commit c8081ed into dev Sep 21, 2024
1 check passed
@applepie7864 applepie7864 deleted the ryan-jesse/announcement-homepage-component branch February 25, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanSh3n RyanSh3n RyanSh3n approved these changes

@ya5er ya5er Awaiting requested review from ya5er

Assignees

@RyanSh3n RyanSh3n

@jeessh jeessh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeessh @RyanSh3n