Add classroom timepicker #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 670a3b5): https://jump-math-staging--pr612-juliands-add-classro-td0l3hio.web.app (expires Tue, 28 Nov 2023 00:53:39 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c42d8d0d853b05885664a2dd73f8245f4333ae51 |
| @@ -34,6 +34,9 @@ const chakraStyles = ( | |||
| outline: "none", | |||
| }, | |||
| border: "none", | |||
| _disabled: { | |||
| opacity: 1, | |||
There was a problem hiding this comment.
Due to an implementation detail the opacity-based styling for disabled elements was getting applied twice, meaning that this component looked different than other disabled components. Technically this fix belongs in the previous pr but that's already merged so I thought this was fine.
carissa-tang
approved these changes
Nov 20, 2023
Placeholders are sentences, so they should read like one instead of like a title. For example, you probably wouldn't use "Please choose a date" as a title.
jfdoming
force-pushed
the
juliands/add-classroom-timepicker
branch
from
b720768 to
670a3b5
Compare
|
(force push just to rebase on previous PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Add start / end time in classrooms
Implementation description
Update the date picker in the classroom modal to be a DateTimePicker. This PR also includes a bunch of minor UI fixes related to this change; have a look at the commits for a full list.
Steps to test
What should reviewers focus on?
Checklist