Skip to content

Commit

Permalink
chore: push to staging from dev branch (#105)
Browse files Browse the repository at this point in the history
* chore: add staging info to readme

* changed mentions of main branch to dev branch

* Update actions

Co-authored-by: Dhruv Mittal <[email protected]>
  • Loading branch information
annechung and Dhruv Mittal authored Sep 18, 2022
1 parent bcc6f9d commit 76a0e44
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 7 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/firebase-hosting-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ name: Deploy frontend to Firebase Hosting
on:
push:
branches:
- main
- dev
paths:
- "frontend/**"

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/heroku-deploy-dev-ts.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: Deploy backend to Heroku dev environment
on:
push:
branches:
- main
- dev
paths:
- "backend/typescript/**"

Expand Down Expand Up @@ -51,4 +51,4 @@ jobs:
env:
HEROKU_APP_NAME: "${{ secrets.HEROKU_APP_NAME }}"
- name: Push to Heroku
run: git subtree push --prefix backend/typescript heroku main
run: git subtree push --prefix backend/typescript heroku dev
14 changes: 10 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,16 +79,22 @@ docker exec -it scv2_ts_backend /bin/bash -c "yarn fix"
docker exec -it scv2_ts_backend /bin/bash -c "yarn test"
```

## Deployments
### Staging
**Backend (Heroku):** https://focus-on-nature.herokuapp.com/
**Frontend (Firebase):** https://focus-on-nature.web.app/
Whenever a PR is merged our github actions will push the updated dev branch to the staging environments.

## Version Control Guide

### Branching

- Branch off of `main` for all feature work and bug fixes, creating a "feature branch". Prefix the feature branch name with your name. The branch name should be in kebab case and it should be short and descriptive. E.g. `sherry/readme-update`
- To integrate changes on `main` into your feature branch, **use rebase instead of merge**
- Branch off of `dev` for all feature work and bug fixes, creating a "feature branch". Prefix the feature branch name with your name. The branch name should be in kebab case and it should be short and descriptive. E.g. `sherry/readme-update`
- To integrate changes on `dev` into your feature branch, **use rebase instead of merge**

```bash
# currently working on feature branch, there are new commits on main
git pull origin main --rebase
# currently working on feature branch, there are new commits on dev
git pull origin dev --rebase

# if there are conflicts, resolve them and then:
git add .
Expand Down

0 comments on commit 76a0e44

Please sign in to comment.