Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created payments table #40

Merged
merged 5 commits into from
Jun 19, 2024
Merged

created payments table #40

merged 5 commits into from
Jun 19, 2024

Conversation

roskzhu
Copy link
Collaborator

@roskzhu roskzhu commented May 26, 2024

Notion ticket link

create payments table

Implementation description

  • defined schema for payments table
  • created and applied migration

Steps to test

  1. NA

What should reviewers focus on?

  • Please review our schema columns :)

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@roskzhu roskzhu requested a review from mat-ng May 26, 2024 18:14
@mat-ng
Copy link
Collaborator

mat-ng commented May 28, 2024

Great work so far! I tested that the Payment table gets created successfully and I like the constraints.

I think the Donation table referencing the Payment table ultimately makes more sense. These changes would help massively 🙏

@roskzhu roskzhu requested a review from mat-ng June 6, 2024 18:37
@roskzhu roskzhu changed the title Create payment table creating payments table Jun 6, 2024
@roskzhu roskzhu changed the title creating payments table created payments table Jun 6, 2024
@mat-ng
Copy link
Collaborator

mat-ng commented Jun 10, 2024

de_ts_backend  |     Property 'payment_id' is missing in type '{ user_id: string; amount: number; donation_date: Date; cause_id: number; is_recurring: Recurrence; confirmation_email_sent: boolean; }' but required in type 'DonationUncheckedCreateInput'.

Thanks for making those changes to the Donation table! But a few more changes are going to be needed in the Donation service. For example, we'll have to pass in a payment_id parameter when we create a Donation. Are you guys able to fix those?

The errors can be seen when you try spinning up the Docker containers.

@roskzhu roskzhu merged commit 866a841 into main Jun 19, 2024
@roskzhu roskzhu deleted the create-payment-table branch June 19, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants