Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrades and Linting fixes #246

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

JennyVong
Copy link
Contributor

Notion ticket link

Upgrade Dependencies

Implementation description

  • Upgraded current dependencies within CAS package
  • Added react-phone-number-input

Steps to test

  1. remove pre-existing node_module and package-lock.json rm -rf node_modules package-lock.json
  2. clear cache mayhaps? npm cache clear --force
  3. run npm install
  4. run linter npm run lint
  5. run docker per dev cheat sheet

What should reviewers focus on?

  • right now there's a lot of eslint-disable regarding unused props because I'm not sure what we'll be using in future tickets and what props we don't need --can you look into this for me and then we can get rid of unneeded props?
  • did not add @react-pfd/renderer since it caused some problems which I'll look into for report generation
  • some packages have been deprecated which does not interfere with the overall build but should be something to look into to prepare for deployment

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

Copy link

github-actions bot commented Mar 24, 2024

Visit the preview URL for this PR (updated for commit 3e0d67a):

https://childrens-aid-society--pr246-jenny-version-update-5gp8nr2e.web.app

(expires Sun, 07 Apr 2024 03:31:18 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93f6cb7bff946a1edd29d684408e6d31442cf0b1

@JennyVong JennyVong force-pushed the jenny/version-updates-lint-fixes branch from c01f59e to 3e0d67a Compare March 31, 2024 03:28
Copy link
Contributor

@vaaranan-y vaaranan-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks guys!

@vaaranan-y vaaranan-y merged commit b8155da into main Mar 31, 2024
7 checks passed
@vaaranan-y vaaranan-y deleted the jenny/version-updates-lint-fixes branch March 31, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants