Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auth blocking of the app #207

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JoshuaYe
Copy link
Contributor

@JoshuaYe JoshuaYe commented Oct 3, 2023

Notion ticket link

Implement auth blocking of the app

Implementation description

  • Made home, intake, visit, case overview, and cases private routes (ie. only authorized users can access)

Steps to test

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

@JoshuaYe JoshuaYe requested a review from Ezzhingy October 3, 2023 01:13
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Visit the preview URL for this PR (updated for commit 7cadfb1):

https://childrens-aid-society--pr207-josh-auth-app-auth-b-dep1z9yl.web.app

(expires Tue, 24 Oct 2023 00:13:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 93f6cb7bff946a1edd29d684408e6d31442cf0b1

Copy link
Collaborator

@Ezzhingy Ezzhingy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i messed around and got the auth to work—the PrivateRoutes work as intended! Great work :)

Feel free to move this task to completed in the task dash, but don't merge this yet
We'll merge it once we finish most of the other implementations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants