-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Chakra UI #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized while testing your code that the functions in frontend/src/APIClients
are never called in our application 😭
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some comments about the error handling and alert issues 🫡
01f4730
to
9baab63
Compare
Followed the steps, had no issues compiling on my end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this Chakra UI ticket! The changes look good, and following the steps you laid out to test, I could run smoothly and get a few Chakra components added to the login page as well, so it seems to work. Once again, great job on this one! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I double-checked that the try-catch statement passes the linter. This is ready to merge, good job!!!
Notion Ticket Link
Install Chakra UI
Implementation Description
Steps to Test
frontend/node_modules
folder. In the frontend directory (cd frontend
), runyarn install
to get a fresh copy of the packages. This won't affect what Docker gives you, but it'll make the local package errors go away.docker compose down
, rebuild the containers withdocker compose up --build
.* The login page will probably show "Script error" (and you'll see something about missing the client_id parameter in the console). Don't worry about it, the "Remove Google Auth for Login" ticket will make the error go away eventually.
Screenshots (optional)
Here's what the Chakra UI button looks like:
![image](https://private-user-images.githubusercontent.com/82423082/307665217-1668d905-3b46-43db-9376-db1539d60461.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNzkzNTgsIm5iZiI6MTczOTM3OTA1OCwicGF0aCI6Ii84MjQyMzA4Mi8zMDc2NjUyMTctMTY2OGQ5MDUtM2I0Ni00M2RiLTkzNzYtZGIxNTM5ZDYwNDYxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE2NTA1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI0M2Q0MTcyMTdhMjA5MzE0OGVjMzg1MGRlNTlmYjRmNTI3YTAyMmM0NDlhYjcwYTc1NjNhZWQ4NmI1ZWM4MWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.hyXP8LtIXlr4CQew2bShoW8SrOGqF0_QsiTa1y4FvIg)
If you want to also plop a component somewhere to try it out, check out the docs: https://chakra-ui.com/docs/components
Checklist
Linting & Formatting
Mac
Windows