-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Task Schema #23
Task Schema #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!!! 🤠
backend/models/task.model.ts
Outdated
}, | ||
expiry: { | ||
type: Date, | ||
required: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also not sure - should every task be required to have an expiry field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expiry
should be optional as their on-boarding tasks never expire
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! There are two quick fixes to make, but after that it will be ready to merge!
backend/models/task.model.ts
Outdated
}, | ||
description: { | ||
type: String, | ||
required: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be optional
backend/models/task.model.ts
Outdated
}, | ||
dueDate: { | ||
type: Date, | ||
required: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!! This is ready to merge 👍
Notion Ticket Link
Create Tasks Schema
Implementation Description
Steps to Test
Testing will be completed when Schema is first used.
What should reviewers focus on?
Screenshots (optional)
Checklist
Linting & Formatting
Mac
Windows