Skip to content

Commit

Permalink
resolve linting warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
SohailSayed committed Mar 1, 2024
1 parent d10b93c commit 603eb3c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
2 changes: 0 additions & 2 deletions backend/services/implementations/userService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,13 +143,11 @@ class UserService implements IUserService {
async createUser(

Check failure on line 143 in backend/services/implementations/userService.ts

View workflow job for this annotation

GitHub Actions / run-lint

Replace `⏎····user:·CreateUserDTO,⏎····authId?:·string,⏎··` with `user:·CreateUserDTO,·authId?:·string`
user: CreateUserDTO,
authId?: string,

Check warning on line 145 in backend/services/implementations/userService.ts

View workflow job for this annotation

GitHub Actions / run-lint

'authId' is defined but never used
signUpMethod = "PASSWORD",
): Promise<UserDTO> {
let newUser: User;
let firebaseUser: firebaseAdmin.auth.UserRecord;

try {
// signUpMethod === PASSWORD
firebaseUser = await firebaseAdmin.auth().createUser({
email: user.email,
password: user.password,
Expand Down
12 changes: 2 additions & 10 deletions backend/services/interfaces/userService.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
import {
CreateUserDTO,
Role,
UpdateUserDTO,
UserDTO,
} from "../../types";
import { CreateUserDTO, Role, UpdateUserDTO, UserDTO } from "../../types";

interface IUserService {
/**
Expand Down Expand Up @@ -60,10 +55,7 @@ interface IUserService {
* @returns a UserDTO with the created user's information
* @throws Error if user creation fails
*/
createUser(
user: CreateUserDTO,
authId?: string,
): Promise<UserDTO>;
createUser(user: CreateUserDTO, authId?: string): Promise<UserDTO>;

/**
* Update a user.
Expand Down

0 comments on commit 603eb3c

Please sign in to comment.