Skip to content

Conversation

@sarnobat
Copy link

@sarnobat sarnobat commented Oct 13, 2025

@sarnobat sarnobat marked this pull request as draft October 13, 2025 22:05
@sarnobat
Copy link
Author

sarnobat commented Oct 13, 2025

@sylvestre - newbie question:

  • Is it possible to get some feedback on the code changes in this PR before I replicate the same effort for more tests? (I'm also wondering what workflow failures might be invisible to me since it requires maintainer approval)
  • Must all the changes be done in a single pull request? Or can it be done in small changes? (I prefer the latter but understand that that may be unrealistic)

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.88%. Comparing base (69b276a) to head (c98f65b).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #578   +/-   ##
=======================================
  Coverage   88.88%   88.88%           
=======================================
  Files          31       31           
  Lines        6300     6300           
  Branches      324      324           
=======================================
  Hits         5600     5600           
  Misses        578      578           
  Partials      122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sylvestre
Copy link
Contributor

That looks great! And no worries for doing it in the same pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants