Skip to content

Conversation

@michizhou
Copy link

@PineappleIOnic
Copy link
Contributor

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

@michizhou
Copy link
Author

@stnguyen90 I would greatly appreciate if you can review this PR. Please let me know if additional changes are needed.

@stnguyen90
Copy link
Contributor

@michizhou looks like there are merge conflicts. Would you please resolve them?

@michizhou
Copy link
Author

@stnguyen90 I have resolved the merge conflicts. Please let me know if additional changes are needed.

@stnguyen90 stnguyen90 self-requested a review April 3, 2023 15:22
@christyjacob4
Copy link
Contributor

@michizhou thanks a lot for your contributions during Hacktoberfest 2022! The PR will be merged soon after some more reviews.

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. 

$adapter = new Bugsnag($bugsnagKey ? $bugsnagKey : '');
$logger = new Logger($adapter);
$response = $logger->addLog($log);
$this->assertEquals(200, $response);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running this test and it passed, but I don't see any new errors in bugsnag. Were you able to see something in bugsnag?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stnguyen90 I didn't see anything in Bugsnag, as I don't recall sending any errors to Bugsnag. Do you know how we can send errors to Bugsnag to validate these changes? I'm willing to help in any way I can.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michizhou, you can sign up for a trial at BugSnag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚨 Improve Appwrite Logging with Bugsnag Adapter

4 participants