Skip to content

fix(turbopack): fall back after filtering declaration path aliases - #191

Merged
fireairforce merged 1 commit into
utoofrom
zoomdong/dts-paths-fallback
Sep 10, 2026
Merged

fireairforce merged 1 commit into
utoofrom
zoomdong/dts-paths-fallback

Conversation

@fireairforce

@fireairforce fireairforce commented Sep 9, 2026 •

Copy link
Copy Markdown
Member

Summary

When a tsconfig path maps a runtime package import only to .d.ts files, filtering the declarations leaves no candidates. The current conversion turns that into ImportMapping::Ignore, so calling an imported function can emit (void 0)() instead of resolving the package's JavaScript entry.

Keep an empty alternatives mapping when declaration filtering removes every candidate. Resolution then falls back to the original package request, while the mapping still preserves its precedence over inherited and broader wildcard entries. Explicitly empty path arrays and other ignore mappings retain their existing behavior.

Validation

Validated through the utoo Pack integration harness:

  • The original runtime reproduction fails before the fix with (void 0) is not a function.
  • cargo test -p pack-tests typescript: 12 passed. The companion PR adds one focused snapshot regression for an exact path pointing directly to a package declaration file. It verifies the real JavaScript module and imported function call in the output, using the test harness dummy runtime to keep snapshots small.
  • cargo clippy -p turbopack-resolve --all-targets -- -D warnings --no-deps and Rust formatting checks pass.

Public reproduction: https://github.com/fireairforce/turbopack-dts-paths-repro

Companion utoo integration and regression test: utooland/utoo#3344

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-10T02:25:39.389177Z 22c0a8c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@fireairforce
fireairforce merged commit 4e1e398 into utoo Sep 10, 2026
17 of 30 checks passed
fireairforce added a commit that referenced this pull request Sep 14, 2026
Rebased onto vercel/next.js canary 3c9d1ca. Includes the previous
utoo follow-ups:

- feat(turbo-tasks): expose completed task count (#187)
- fix(turbopack): preserve CSS chunk order in identity (#188)
- feat(turbopack): support React 17 compiler target (#189)
- fix(turbopack): honor default chunk content hashing (#190)
- fix(turbopack): fall back after filtering declaration path aliases (#191)
- fix(turbopack): handle undefined defaults in dynamic URLs (#192)

Adaptations for this sync:

- swc v77: build Function.body as FunctionBody in async_module.rs
- turbo-tasks GC roots: extend the wasm in-memory backing storage stub
- lazy dynamic imports: port the follow-reexports evaluation/side-effect
  semantics into module_canonicalization.rs
- strict factory chunks: keep browser_global_ident and compress options
  in the rewritten chunk emitters

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant