Repository navigation
fix(turbopack): fall back after filtering declaration path aliases - #191
Merged
Merged
Conversation
fireairforce
marked this pull request as ready for review
September 10, 2026 02:21
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
fireairforce
added a commit
that referenced
this pull request
Sep 14, 2026
Rebased onto vercel/next.js canary 3c9d1ca. Includes the previous utoo follow-ups: - feat(turbo-tasks): expose completed task count (#187) - fix(turbopack): preserve CSS chunk order in identity (#188) - feat(turbopack): support React 17 compiler target (#189) - fix(turbopack): honor default chunk content hashing (#190) - fix(turbopack): fall back after filtering declaration path aliases (#191) - fix(turbopack): handle undefined defaults in dynamic URLs (#192) Adaptations for this sync: - swc v77: build Function.body as FunctionBody in async_module.rs - turbo-tasks GC roots: extend the wasm in-memory backing storage stub - lazy dynamic imports: port the follow-reexports evaluation/side-effect semantics into module_canonicalization.rs - strict factory chunks: keep browser_global_ident and compress options in the rewritten chunk emitters Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a tsconfig path maps a runtime package import only to
.d.tsfiles, filtering the declarations leaves no candidates. The current conversion turns that intoImportMapping::Ignore, so calling an imported function can emit(void 0)()instead of resolving the package's JavaScript entry.Keep an empty alternatives mapping when declaration filtering removes every candidate. Resolution then falls back to the original package request, while the mapping still preserves its precedence over inherited and broader wildcard entries. Explicitly empty path arrays and other ignore mappings retain their existing behavior.
Validation
Validated through the utoo Pack integration harness:
(void 0) is not a function.cargo test -p pack-tests typescript: 12 passed. The companion PR adds one focused snapshot regression for an exact path pointing directly to a package declaration file. It verifies the real JavaScript module and imported function call in the output, using the test harness dummy runtime to keep snapshots small.cargo clippy -p turbopack-resolve --all-targets -- -D warnings --no-depsand Rust formatting checks pass.Public reproduction: https://github.com/fireairforce/turbopack-dts-paths-repro
Companion utoo integration and regression test: utooland/utoo#3344