Add OSI contributions #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Students were getting confused and thinking they had selected an option when they were really just hovering on it. Also, touching the option results in it remaining "hovered" even after the finger is long gone.
This is done in addition to changing the title as was done previously.
* Use document.visibilityState to determine when the tab is not focused. This avoids a race condition where the tab is unfocused before the page has loaded, so the app can't detect it. Also, this lets us get rid of an event handler. * Forcefully close the notification that was previously open, to improve reliability of seeing the new notification.
Thanks @embeddedt Co-authored-by: embeddedt <[email protected]>
* eslint setup (missing husky integration) #62 * Fixed eslint errors * Added lint:fix script to package.json * added server pre-commit husky Co-authored-by: Shubh Bapna <[email protected]>
* Removed use of any. Referencing issue #63 * Implemented PR type suggestions * �Fixed pull request suggestions. * Fixed middleware sending response * Fixed pull request suggestions * Removed unnecessary undefined from arguments * Changed string check to check for empty strings * Fixed eslint errors
* Added missing import statement * Fixed eslint
* Make sure polling results are only sent to instructors * Add UserType enum
Several QoL (quality of life) improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge 2022 OSI contributions, with most of contributions related to UI improvements and formatting
Related issues: #77 #63 #62 #50 #72