Skip to content

Themes: upload icon on the button that publishes a theme - #2417

Closed
utkarshdalal wants to merge 1 commit into
masterfrom
theme-upload-icon
Closed

utkarshdalal wants to merge 1 commit into
masterfrom
theme-upload-icon

Conversation

@utkarshdalal

@utkarshdalal utkarshdalal commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Description

The button on an installed theme that publishes it to the community list showed the share icon, which reads as "send this file to someone". It now shows an upload icon. The label and the dialog are unchanged.

Recording

Not recorded: one icon swap.

Type of Change

  • Bug fix
  • Performance / stability improvement
  • Compatibility improvements
  • Other (requires prior approval)

Checklist

  • If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
  • This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
  • I have attached a recording of the change.
  • I have read and agree to the contribution guidelines in CONTRIBUTING.md.

Summary by cubic

The button that publishes an installed theme to the community list now shows an upload icon instead of a share icon, which previously read as "send this file to someone". The label and the publish dialog are unchanged.

Written for commit 5e82869. Summary will update on new commits.

View guided diff Turn on auto-fix

Summary by CodeRabbit

  • Style
    • Updated the installed-theme sharing action to display an upload icon.

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The installed-theme share action now displays the Upload icon instead of the Share icon. Its click handler and conditional accessibility label are unchanged.

Changes: Installed theme action icon

Layer / File(s) Summary
Update installed-theme action icon
app/src/main/java/app/gamenative/ui/screen/settings/ThemeManagerDialog.kt
The installed-theme share action now displays the Upload icon. Its click handler and conditional accessibility label are unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: Minimal · up to 5e828

This is a cosmetic icon change on the installed-theme publish button. The label and dialog behavior are unchanged, so merge risk is negligible.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the change: the icon on the theme publish button changes to an upload icon. It matches the raw summary, which says ThemeManagerDialog.kt swaps the Share icon for Upload on the publish-…
Description check Passed The description follows the repository template. It explains the change and its reason: the share icon suggested sending a file, so the publish button now shows an upload icon. It marks the Other type…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the change: the icon on the theme publish button changes to an upload icon. It matches the raw summary, which says ThemeManagerDialog.kt swaps the Share icon for Upload on the publish-to-community action, and the PR objectives, which describe the same icon change. The title is short and specific.

Full details: Description check

Explanation

The description follows the repository template. It explains the change and its reason: the share icon suggested sending a file, so the publish button now shows an upload icon. It marks the Other type and checks the required boxes. The recording box is unchecked, and the author gives a reason: a single icon swap. The template asks for a recording, so this gap is noted. The check still passes because the description is mostly complete and the missing recording is a minor item.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ac3c419d-50b5-4c0e-922c-2acb09a0c700
Commits

Reviewing files that changed from the base of the PR and between 4f75807 and 5e82869.

Files selected for processing: 1

  • app/src/main/java/app/gamenative/ui/screen/settings/ThemeManagerDialog.kt

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Turn on auto-fix | Re-trigger cubic

@utkarshdalal

Copy link
Copy Markdown
Owner Author

Folded into #2419.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant