You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Themes: upload icon on the button that publishes a theme - #2417
The button on an installed theme that publishes it to the community list showed the share icon, which reads as "send this file to someone". It now shows an upload icon. The label and the dialog are unchanged.
Recording
Not recorded: one icon swap.
Type of Change
Bug fix
Performance / stability improvement
Compatibility improvements
Other (requires prior approval)
Checklist
If I have access to #code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.
This change aligns with the current project scope (core functionality, stability, or performance). If not, it has been explicitly approved beforehand.
I have attached a recording of the change.
I have read and agree to the contribution guidelines in CONTRIBUTING.md.
Summary by cubic
The button that publishes an installed theme to the community list now shows an upload icon instead of a share icon, which previously read as "send this file to someone". The label and the publish dialog are unchanged.
Written for commit 5e82869. Summary will update on new commits.
Summary by CodeRabbit
Style
Updated the installed-theme sharing action to display an upload icon.
No actionable comments were generated in the recent review.
Walkthrough
The installed-theme share action now displays the Upload icon instead of the Share icon. Its click handler and conditional accessibility label are unchanged.
This is a cosmetic icon change on the installed-theme publish button. The label and dialog behavior are unchanged, so merge risk is negligible.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
The title names the change: the icon on the theme publish button changes to an upload icon. It matches the raw summary, which says ThemeManagerDialog.kt swaps the Share icon for Upload on the publish-…
Description check
The description follows the repository template. It explains the change and its reason: the share icon suggested sending a file, so the publish button now shows an upload icon. It marks the Other type…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Title check
Explanation
The title names the change: the icon on the theme publish button changes to an upload icon. It matches the raw summary, which says ThemeManagerDialog.kt swaps the Share icon for Upload on the publish-to-community action, and the PR objectives, which describe the same icon change. The title is short and specific.
Full details: Description check
Explanation
The description follows the repository template. It explains the change and its reason: the share icon suggested sending a file, so the publish button now shows an upload icon. It marks the Other type and checks the required boxes. The recording box is unchecked, and the author gives a reason: a single icon swap. The template asks for a recording, so this gap is noted. The check still passes because the description is mostly complete and the missing recording is a minor item.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The button on an installed theme that publishes it to the community list showed the share icon, which reads as "send this file to someone". It now shows an upload icon. The label and the dialog are unchanged.
Recording
Not recorded: one icon swap.
Type of Change
Checklist
#code-changes, I have discussed this change there and it has been green-lighted. If I do not have access, I have still provided clear context in this PR. If I skip both, I accept that this change may face delays in review, may not be reviewed at all, or may be closed.CONTRIBUTING.md.Summary by cubic
The button that publishes an installed theme to the community list now shows an upload icon instead of a share icon, which previously read as "send this file to someone". The label and the publish dialog are unchanged.
Written for commit 5e82869. Summary will update on new commits.
Summary by CodeRabbit