Remove VectorFailingToInput alert #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffilippopoulos
approved these changes
Jul 5, 2024
The alert is too generic given how different input sources work. Some only run on some nodes, and some have so little input that it's ok to be 0 for a long time (like falco alerts on gcp or merit). This should be replaced by specific alerts per input source, considering it's expected input rates, if any.
hectorhuertas
force-pushed
the
remove-vector-input-alert
branch
from
1e084fd to
239dbec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The alert is too generic given how different input sources work. Some only run on some nodes, and some have so little input that it's ok to be 0 for a long time (like falco alerts on gcp or merit).
This should be replaced by specific alerts per input source, considering it's expected input rates, if any.